Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move additional arch files to core module #1107

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Moves some additional architecture files to the core module which allow capturing log/event data types. This required some minor refactoring to get around the public API Severity enum not being accessible from that module.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 16, 2024 12:07
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (b8d9570) to head (c515748).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           migrate-arch-classes    #1107      +/-   ##
========================================================
- Coverage                 79.64%   79.64%   -0.01%     
========================================================
  Files                       421      421              
  Lines                     10741    10747       +6     
  Branches                   1765     1766       +1     
========================================================
+ Hits                       8555     8559       +4     
- Misses                     1405     1406       +1     
- Partials                    781      782       +1     
Files Coverage Δ
.../embracesdk/internal/arch/destination/LogWriter.kt 100.00% <ø> (ø)
...racesdk/internal/arch/destination/LogWriterImpl.kt 95.00% <100.00%> (+0.88%) ⬆️
...bracesdk/internal/capture/aei/AeiDataSourceImpl.kt 84.46% <100.00%> (ø)
...esdk/internal/capture/crash/CrashDataSourceImpl.kt 89.06% <100.00%> (ø)
...roid/embracesdk/internal/logs/EmbraceLogService.kt 93.93% <100.00%> (ø)
...d/embracesdk/internal/ndk/NativeCrashDataSource.kt 90.47% <100.00%> (ø)
...al/network/logging/NetworkCaptureDataSourceImpl.kt 100.00% <100.00%> (ø)
...al/telemetry/errors/InternalErrorDataSourceImpl.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the migrate-arch-classes branch from b8d9570 to efc2069 Compare July 17, 2024 10:04
@fractalwrench fractalwrench merged commit e366c50 into migrate-arch-classes Jul 17, 2024
1 check passed
@fractalwrench fractalwrench deleted the move-extra-arch branch July 17, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants