Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularise payload classes #1114

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Modularise payload classes #1114

merged 1 commit into from
Jul 17, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Modularises some of the payload classes into the payload module.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 16, 2024 16:39
Copy link
Contributor

github-actions bot commented Jul 16, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (1b7ccc6) to head (820645f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
- Coverage   79.76%   79.45%   -0.31%     
==========================================
  Files         419      368      -51     
  Lines       10735    10393     -342     
  Branches     1763     1744      -19     
==========================================
- Hits         8563     8258     -305     
+ Misses       1394     1357      -37     
  Partials      778      778              
Files Coverage Δ
...dk/internal/config/behavior/NetworkBehaviorImpl.kt 78.04% <83.33%> (+0.54%) ⬆️

... and 33 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the move-payload-classes branch from 2b7ecee to 820645f Compare July 17, 2024 10:34
@fractalwrench fractalwrench merged commit 37a08b6 into master Jul 17, 2024
5 checks passed
@fractalwrench fractalwrench deleted the move-payload-classes branch July 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants