Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup api module #1115

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Setup api module #1115

merged 1 commit into from
Jul 17, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Creates an embrace-android-api module. This will contain some but not all of our public facing API, as we want our core module to have access to some but not all symbols in our public API, but obviously want to maintain visibility for end-users.

This required a bit of an alteration to how Dokka is configured but was otherwise a reasonably straightforward change.

@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 17, 2024 15:28
Copy link
Contributor

github-actions bot commented Jul 17, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.27%. Comparing base (9f5b3b8) to head (4e20cfa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   80.89%   81.27%   +0.38%     
==========================================
  Files         376      437      +61     
  Lines       10938    11583     +645     
  Branches     1768     1788      +20     
==========================================
+ Hits         8848     9414     +566     
- Misses       1310     1384      +74     
- Partials      780      785       +5     
Files Coverage Δ
...n/java/io/embrace/android/embracesdk/Severity.java 100.00% <ø> (ø)

... and 64 files with indirect coverage changes

@fractalwrench fractalwrench merged commit 7b21006 into master Jul 17, 2024
5 checks passed
@fractalwrench fractalwrench deleted the setup-api-module branch July 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants