Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularise core module #1133

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Continues modularisation by moving some dependency injection to the core module.

@fractalwrench fractalwrench requested a review from priettt July 19, 2024 16:46
@fractalwrench fractalwrench requested a review from a team as a code owner July 19, 2024 16:46
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.25%. Comparing base (a176c7b) to head (300e920).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           move-data-sources    #1133   +/-   ##
==================================================
  Coverage              81.24%   81.25%           
==================================================
  Files                    439      439           
  Lines                  11577    11580    +3     
  Branches                1789     1789           
==================================================
+ Hits                    9406     9409    +3     
  Misses                  1387     1387           
  Partials                 784      784           
Files Coverage Δ
...o/embrace/android/embracesdk/internal/BuildInfo.kt 68.75% <100.00%> (ø)
...id/embracesdk/internal/injection/CoreModuleImpl.kt 68.75% <100.00%> (ø)
...bracesdk/internal/injection/DependencyInjection.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/registry/ServiceRegistry.kt 100.00% <100.00%> (ø)
...acesdk/internal/capture/metadata/AppEnvironment.kt 100.00% <100.00%> (ø)
...dk/internal/injection/AndroidServicesModuleImpl.kt 100.00% <100.00%> (ø)
...racesdk/internal/EmbraceAndroidResourcesService.kt 0.00% <0.00%> (ø)
...internal/session/lifecycle/ProcessStateListener.kt 50.00% <50.00%> (ø)
...esdk/internal/session/lifecycle/StartupListener.kt 0.00% <0.00%> (ø)
...nal/session/lifecycle/ActivityLifecycleListener.kt 0.00% <0.00%> (ø)

Base automatically changed from move-data-sources to move-span-data-source July 23, 2024 08:32
@fractalwrench fractalwrench merged commit da96dfe into move-span-data-source Jul 23, 2024
1 of 2 checks passed
@fractalwrench fractalwrench deleted the move-core-module branch July 23, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants