Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null for traceparent generator #1137

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Allows null as a valid value when generating a traceparent. This is because the feature may not be enabled in which case we want to avoid generating a traceparent.

Testing

Updated unit test coverage.

@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 24, 2024 15:23
Copy link
Contributor

github-actions bot commented Jul 24, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (f477bc3) to head (27e93e8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
- Coverage   82.94%   82.93%   -0.01%     
==========================================
  Files         435      435              
  Lines       11284    11286       +2     
  Branches     1750     1751       +1     
==========================================
+ Hits         9359     9360       +1     
  Misses       1149     1149              
- Partials      776      777       +1     
Files Coverage Δ
...in/java/io/embrace/android/embracesdk/Embrace.java 81.43% <ø> (ø)
...internal/api/delegate/NetworkRequestApiDelegate.kt 52.63% <66.66%> (-0.31%) ⬇️

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the traceparent-generator branch from faac544 to 27e93e8 Compare July 29, 2024 09:54
@fractalwrench fractalwrench merged commit 46d593a into master Jul 29, 2024
6 checks passed
@fractalwrench fractalwrench deleted the traceparent-generator branch July 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants