Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to OTel semantic convention keys #1139

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

priettt
Copy link
Contributor

@priettt priettt commented Jul 25, 2024

  • Altered the keys used in the payload to match OTel’s semantic conventions.
  • Deleted unused SchemaType objects.

Backend already supports the new keys.

Alter the keys used in the payload to match OTel’s semantic conventions.
Deleted unused SchemaType objects.
@priettt priettt requested a review from a team as a code owner July 25, 2024 15:30
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.43%. Comparing base (756348a) to head (f30c798).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   81.25%   81.43%   +0.18%     
==========================================
  Files         439      439              
  Lines       11580    11546      -34     
  Branches     1789     1789              
==========================================
- Hits         9409     9403       -6     
+ Misses       1387     1358      -29     
- Partials      784      785       +1     
Files Coverage Δ
...roid/embracesdk/internal/arch/schema/SchemaType.kt 99.30% <100.00%> (+18.51%) ⬆️
...mbracesdk/internal/spans/PersistableEmbraceSpan.kt 100.00% <ø> (ø)
...e/android/embracesdk/internal/anr/AnrOtelMapper.kt 87.80% <100.00%> (ø)
...embracesdk/internal/anr/ndk/NativeAnrOtelMapper.kt 80.00% <100.00%> (ø)
...racesdk/internal/arch/destination/LogWriterImpl.kt 95.65% <100.00%> (ø)
...esdk/internal/capture/crash/CrashDataSourceImpl.kt 91.89% <100.00%> (ø)
...d/embracesdk/internal/ndk/NativeCrashDataSource.kt 92.30% <100.00%> (ø)
...al/network/logging/EmbraceNetworkLoggingService.kt 97.61% <100.00%> (ø)
...sdk/internal/opentelemetry/EmbraceAttributeKeys.kt 100.00% <ø> (ø)
...ternal/opentelemetry/OpenTelemetryConfiguration.kt 96.96% <100.00%> (ø)
... and 5 more

... and 4 files with indirect coverage changes

@priettt priettt merged commit 92d840a into master Jul 25, 2024
5 of 6 checks passed
@priettt priettt deleted the otel-semantic-conventions branch July 25, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants