Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OpenTelemetry module #1142

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Move OpenTelemetry module #1142

merged 3 commits into from
Jul 29, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Moves OpenTelemetryModule and associated classes to embrace-android-core. This will allow features to access the symbol & initialize themselves in a declarative manner.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested review from fnewberg, bidetofevil and a team as code owners July 26, 2024 11:04
@fractalwrench fractalwrench force-pushed the move-otel-module branch 2 times, most recently from 32acf93 to 2a04dcd Compare July 26, 2024 12:28
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.45%. Comparing base (ceff351) to head (2a04dcd).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           move-init-module    #1142      +/-   ##
====================================================
- Coverage             81.46%   81.45%   -0.02%     
====================================================
  Files                   439      440       +1     
  Lines                 11536    11537       +1     
  Branches               1784     1784              
====================================================
- Hits                   9398     9397       -1     
- Misses                 1356     1358       +2     
  Partials                782      782              
Files Coverage Δ
.../android/embracesdk/internal/InternalTracingApi.kt 100.00% <ø> (ø)
.../io/embrace/android/embracesdk/spans/TracingApi.kt 93.87% <ø> (ø)
...acesdk/internal/arch/schema/AppTerminationCause.kt 100.00% <100.00%> (ø)
...bracesdk/internal/logs/EmbraceLogRecordExporter.kt 63.63% <100.00%> (ø)
...racesdk/internal/logs/EmbraceLogRecordProcessor.kt 100.00% <100.00%> (ø)
...sdk/internal/opentelemetry/EmbraceAttributeKeys.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/spans/CurrentSessionSpan.kt 100.00% <100.00%> (ø)
...ce/android/embracesdk/internal/spans/EmbraceExt.kt 100.00% <100.00%> (ø)
...droid/embracesdk/internal/spans/EmbraceSpanData.kt 88.88% <ø> (ø)
...d/embracesdk/internal/spans/EmbraceSpanExporter.kt 55.55% <ø> (ø)
... and 10 more

... and 3 files with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 9f9d877 into move-init-module Jul 29, 2024
2 checks passed
@fractalwrench fractalwrench deleted the move-otel-module branch July 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants