Capture build id for NDK stackframes #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
ndk-unwind-debugging
branch
from
18df76e to
f8eefab
Compare
fractalwrench
changed the title
priettt
approved these changes
Oct 25, 2023
chawco
approved these changes
Oct 26, 2023
fractalwrench
force-pushed
the
ndk-unwind-debugging
branch
from
f8eefab to
942101b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Captures the build id (
.note.gnu.build.id) when unwinding the stack during crashes. This functionality is enabled in newer versions of libunwindstack & will simplify the logic required to symbolicate on our backend. This is serialized under the keyfr[0].build_idof the base 64 encoded crash message.Testing
Intercepted JSON to confirm that the
build_idfield is set in the payload, and verified native crashes are displayed in the dashboard.with_build_id.json