Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NDK tests and fixtures after metadata and appState removal #1771

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Dec 19, 2024

Goal

Remove obsolete tests and change test fixtures to reflect the schema update.

@bidetofevil bidetofevil requested a review from a team as a code owner December 19, 2024 16:46
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bidetofevil bidetofevil requested a review from priettt December 19, 2024 16:47
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (26832fa) to head (fd290d3).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
- Coverage   85.47%   85.45%   -0.02%     
==========================================
  Files         466      466              
  Lines       10953    10953              
  Branches     1625     1625              
==========================================
- Hits         9362     9360       -2     
- Misses        864      866       +2     
  Partials      727      727              

see 1 file with indirect coverage changes

Copy link
Collaborator Author

bidetofevil commented Dec 19, 2024

Merge activity

  • Dec 19, 12:24 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 12:25 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 19, 12:31 PM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'gradle-test').
  • Dec 19, 2:00 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 5c732ce into main Dec 19, 2024
6 checks passed
@bidetofevil bidetofevil deleted the hho/update-ndk-tests branch December 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants