Add tests for URLConnection wrappers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
bidetofevil
force-pushed
the
hho/urlconnection-tests
branch
from
0faef4b to
86d199e
Compare
…ods in the delegate
bidetofevil
force-pushed
the
hho/urlconnection-tests
branch
from
86d199e to
472e9e5
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 72.67% 73.80% +1.13%
==========================================
Files 305 305
Lines 9990 9992 +2
Branches 1438 1438
==========================================
+ Hits 7260 7375 +115
+ Misses 2162 2049 -113
Partials 568 568
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add tests to verify that our network wrappers actually call the appropriate methods that they are wrapping. Along the way, added some more comments and did some renaming.