Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recordnetwork methods with primitive data types #37

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

nelsitoPuglisi
Copy link
Contributor

@nelsitoPuglisi nelsitoPuglisi commented Oct 31, 2023

Goal

Added an override for our Unity SDK to avoid using custom data types which are not used.

@nelsitoPuglisi nelsitoPuglisi requested a review from a team as a code owner October 31, 2023 14:40
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #37 (d38fdec) into master (cc08fa6) will increase coverage by 0.96%.
Report is 4 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   72.65%   73.61%   +0.96%     
==========================================
  Files         305      305              
  Lines       10016    10041      +25     
  Branches     1444     1446       +2     
==========================================
+ Hits         7277     7392     +115     
+ Misses       2167     2077      -90     
  Partials      572      572              
Files Coverage Δ
...e/android/embracesdk/UnityInternalInterfaceImpl.kt 56.62% <0.00%> (-21.71%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsitoPuglisi nelsitoPuglisi merged commit b362771 into master Oct 31, 2023
3 of 4 checks passed
@nelsitoPuglisi nelsitoPuglisi deleted the nelson/unity-record-network branch October 31, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants