Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Delivery Retry logic outside EmbraceApiService. #49

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

lucaslabari
Copy link
Contributor

Goal

  • Moved logic related to retry failed network calls from EmbraceApiService to a new class EmbraceDeliveryRetryManager.
  • Moved related unit tests too.

Testing

  • Updated existing unit tests.

@lucaslabari lucaslabari requested a review from a team as a code owner November 7, 2023 16:11
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #49 (4dae99c) into master (143544f) will decrease coverage by 0.30%.
Report is 7 commits behind head on master.
The diff coverage is 70.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   73.76%   73.47%   -0.30%     
==========================================
  Files         305      306       +1     
  Lines       10053    10070      +17     
  Branches     1447     1448       +1     
==========================================
- Hits         7416     7399      -17     
- Misses       2067     2103      +36     
+ Partials      570      568       -2     
Files Coverage Δ
...oid/embracesdk/injection/EssentialServiceModule.kt 95.58% <100.00%> (+0.20%) ⬆️
.../android/embracesdk/comms/api/EmbraceApiService.kt 19.07% <14.28%> (-28.37%) ⬇️
...esdk/comms/delivery/EmbraceDeliveryRetryManager.kt 73.97% <73.97%> (ø)

... and 3 files with indirect coverage changes

@lucaslabari lucaslabari merged commit eded592 into master Nov 7, 2023
3 of 4 checks passed
@lucaslabari lucaslabari deleted the lucas/refactor_delivery_retry branch November 7, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants