Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch payload message collator depending on config #561

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Switches the payload message collator depending on config. This is not hooked up to the delivery service yet so won't affect production payloads.

Testing

Added unit tests.

@fractalwrench fractalwrench requested a review from a team as a code owner March 13, 2024 15:53
Copy link
Contributor

@leandro-godon leandro-godon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (3755a17) to head (5d911c5).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           add-payload-flag     #561      +/-   ##
====================================================
- Coverage             80.22%   80.21%   -0.02%     
====================================================
  Files                   413      413              
  Lines                 11024    11027       +3     
  Branches               1619     1620       +1     
====================================================
+ Hits                   8844     8845       +1     
- Misses                 1532     1535       +3     
+ Partials                648      647       -1     
Files Coverage Δ
...d/embracesdk/session/message/PayloadFactoryImpl.kt 93.02% <100.00%> (+0.25%) ⬆️

... and 2 files with indirect coverage changes

Base automatically changed from add-payload-flag to master March 14, 2024 06:46
@fractalwrench fractalwrench merged commit 7c7954a into master Mar 14, 2024
3 checks passed
@fractalwrench fractalwrench deleted the switch-collator branch March 14, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants