Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated LogPayload. #563

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Remove duplicated LogPayload. #563

merged 1 commit into from
Mar 14, 2024

Conversation

lucaslabari
Copy link
Contributor

Goal

  • Removed duplicated LogPayload class, so we use only the one in the payload package.
  • I will remove other duplications in separate PRs.

Testing

  • Relied on existing tests.
  • Updated tests.

@lucaslabari lucaslabari requested a review from a team as a code owner March 13, 2024 21:24
fractalwrench
fractalwrench approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaslabari lucaslabari merged commit 2d6036d into master Mar 14, 2024
2 checks passed
@lucaslabari lucaslabari deleted the lucas/remove_duplicated_log_payload branch March 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucaslabari @fractalwrench