Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to EmbraceApiService #60

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Nov 13, 2023

Goal

Add more tests for EmbraceApiService so that we can more safely refactor it and ApiClientImpl

Testing

Added happy path tests - additional tests will be added to handle the boundary cases.

Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #60 (c459bce) into hho/apiservice-cleanup (bfc8311) will increase coverage by 0.72%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           hho/apiservice-cleanup      #60      +/-   ##
==========================================================
+ Coverage                   75.00%   75.72%   +0.72%     
==========================================================
  Files                         307      307              
  Lines                       10053    10052       -1     
  Branches                     1455     1455              
==========================================================
+ Hits                         7540     7612      +72     
+ Misses                       1933     1846      -87     
- Partials                      580      594      +14     
Files Coverage Δ
...brace/android/embracesdk/comms/api/CachedConfig.kt 100.00% <100.00%> (ø)
.../android/embracesdk/comms/api/EmbraceApiService.kt 76.69% <100.00%> (+49.82%) ⬆️
...esdk/comms/delivery/EmbraceDeliveryRetryManager.kt 73.97% <100.00%> (ø)
.../android/embracesdk/config/EmbraceConfigService.kt 85.44% <100.00%> (ø)

... and 3 files with indirect coverage changes

@bidetofevil bidetofevil marked this pull request as ready for review November 13, 2023 08:48
@bidetofevil bidetofevil requested a review from a team as a code owner November 13, 2023 08:48
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from hho/apiservice-cleanup to master November 13, 2023 18:01
@bidetofevil bidetofevil merged commit 9034693 into master Nov 13, 2023
3 checks passed
@bidetofevil bidetofevil deleted the hho/api-service-test branch November 13, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants