Extract logic for constructing ApiRequest from ApiService #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Extracts the logic for constructing
ApiRequest
objects into a separate file. This makes it easier to unit test the business logic for mapping events/sessions toApiRequest
.This is necessary for future work that will give failed request types different priorities on the retry queue. This is mostly just a case of lifting functions into a separate source file, although I did remove/alter some redundant code in a couple of functions.
Testing
Added unit test coverage.