Allow session retries to continue #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidetofevil
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
I think this is fine for a quick fix for 6.1.0, but @lucaslabari will need to apply the retries per end point, so his solution may subsume this - which is fine, as now we have tests to verify that it'll work as it does now
fractalwrench
force-pushed
the
refactor-api-service
branch
2 times, most recently
from
51bf423 to
a511645
Compare
fractalwrench
force-pushed
the
prioritise-session-retries
branch
from
759b7b3 to
a4fc1d8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 75.99% 75.99%
=======================================
Files 309 309
Lines 10057 10058 +1
Branches 1448 1448
=======================================
+ Hits 7643 7644 +1
Misses 1826 1826
Partials 588 588
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows session retries to continue past the limit of 200 requests. There are a couple of ways this could be done - I chose the fairly naive approach of just allowing session requests to go past the arbitrary limit. This approach is fairly simple to implement & it's unlikely that this will add more than a few extra retries to the queue.
Testing
Added unit test coverage.