Convert ApiResponse into a seal class.

[lucaslabari]

Goal

• Convert ApiResponse into a seal class.
• This way ApiClient will always return an ApiResponse of type Success, Failure or Error.

Testing

Updated unit tests.

[codecov]

Codecov Report

Merging #63 (5935e61) into master (2695940) will decrease coverage by 0.15%.
Report is 12 commits behind head on master.
The diff coverage is 43.75%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   76.06%   75.91%   -0.15%     
==========================================
  Files         309      311       +2     
  Lines       10046    10094      +48     
  Branches     1447     1461      +14     
==========================================
+ Hits         7641     7663      +22     
- Misses       1817     1841      +24     
- Partials      588      590       +2     

Files	Coverage Δ
.../embrace/android/embracesdk/comms/api/ApiClient.kt	0.00% <ø> (ø)
...mbrace/android/embracesdk/comms/api/ApiResponse.kt	71.42% <71.42%> (-3.58%)	⬇️
...race/android/embracesdk/comms/api/ApiClientImpl.kt	72.72% <52.94%> (-6.44%)	⬇️
.../android/embracesdk/comms/api/EmbraceApiService.kt	69.47% <29.16%> (-12.58%)	⬇️

... and 20 files with indirect coverage changes

[bidetofevil]

A question overall: we do a lot of logging all over this class. Is it really necessary? Given how many API requests we make, and how standard they all are, we would get a lot of noise that isn't particularly useful

[lucaslabari]

A question overall: we do a lot of logging all over this class. Is it really necessary? Given how many API requests we make, and how standard they all are, we would get a lot of noise that isn't particularly useful

There was already a lot of logs, I thnk we can review which of them makes sense and remove the others on separate PR.

[bidetofevil]

LGTM