Delete the static logger #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2024
This was referenced Mar 29, 2024
bidetofevil
commented
Apr 3, 2024
| @@ -139,23 +136,4 @@ internal class PublicApiTest { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Shortest test life time ever lol
bidetofevil
commented
Apr 3, 2024
| @@ -86,26 +84,6 @@ internal class ModuleInitBootstrapperTest { | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `internal error service hooked up to both static and non-static SDK instance`() { | |||
There was a problem hiding this comment.
So long, farewell.
fractalwrench
approved these changes
Apr 3, 2024
| } | ||
|
|
||
| private static void logError(@NonNull String message, @Nullable Exception e) { | ||
| Embrace.getInstance().getInternalInterface().logError(message, null, null, false); |
There was a problem hiding this comment.
nit: extract getInternalInterface to variable
There was a problem hiding this comment.
I'm going to leave this as is for now. I like idea of making internal error recording more explicit and I'll do this as part of that refactor.
bidetofevil
force-pushed
the
hho/reset-mock-server
branch
from
a568b3c to
d25f1e0
Compare
bidetofevil
force-pushed
the
hho/kill-static-logger
branch
from
bbccb3e to
67efcdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Burn this sucker down with gasoline. We have internal APIs that we expose so hosted SDKs can log stuff like internal errors - just the same APIs in various places so the static logger won't have to be used.
For now, we add helpers in each class so we don't have to make the same internal API calls with default parameters that aren't used. But we should really revisiting our logging strategy, not only in these classes, but elsewhere too.
There doesn't seem to be a rhyme or reason why we log debug/info/error and when we include an exception. Only the ones with exceptions will make it back to the server - the rest, we are just outputting to the logger which likely won't be looked at by anyone. So why even bother? In the off chance we need to see a client logging put to debug a problem? That's a lot of overhead for a very limited use case.
BTW, I touched some Swazzled code, so I'm including @cesarmax22 to make sure this is fine. It should be?
Testing
Modified existing tests to work. CodeConv is yelling again because of some of the exception case logging not being tested. Boo effing hoo.