Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform session gating asynchronously #67

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Performs session gating asynchronously. #55 pointed out that this is something we can feasibly do when saving sessions.

Testing

Updated unit test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner November 14, 2023 11:49
Base automatically changed from refactor-async-end to master November 14, 2023 11:55
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #67 (967e318) into master (ef6fc3b) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 84.84%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   76.03%   76.03%           
=======================================
  Files         309      309           
  Lines       10046    10041    -5     
  Branches     1447     1447           
=======================================
- Hits         7638     7635    -3     
+ Misses       1820     1818    -2     
  Partials      588      588           
Files Coverage Δ
...ace/android/embracesdk/injection/DeliveryModule.kt 100.00% <100.00%> (ø)
...race/android/embracesdk/injection/SessionModule.kt 100.00% <ø> (ø)
...brace/android/embracesdk/session/SessionHandler.kt 88.84% <100.00%> (-0.43%) ⬇️
...mbracesdk/comms/delivery/EmbraceDeliveryService.kt 61.60% <82.75%> (+0.76%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@fractalwrench fractalwrench merged commit 1fd4228 into master Nov 14, 2023
@fractalwrench fractalwrench deleted the gate-session-async branch November 14, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants