-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate lifecycle callbacks for activity + process state #69
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 76.06% 76.05% -0.01%
==========================================
Files 309 311 +2
Lines 10046 10074 +28
Branches 1447 1450 +3
==========================================
+ Hits 7641 7662 +21
- Misses 1817 1824 +7
Partials 588 588
|
} | ||
|
||
@Nullable | ||
ActivityTracker getActivityLifecycleTracker() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who calls this? If we don't need this I'd rather not have it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EmbraceAutomaticVerification
calls it (and other services) unfortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Goal
Separates the lifecycle callbacks for the activity + process state. Currently these are implemented together in the same class (
ActivityService
) but these are distinct responsibilities so we should separate them.I have refactored the implementation so that
ProcessStateService
is responsible for tracking the process foreground/background state, and thatActivityTracker
is responsible for tracking activity lifecycle callbacks.Testing
Updated existing test coverage.