-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getSdkCurrentTime to internal interface #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8 +/- ##
==========================================
+ Coverage 72.72% 72.74% +0.01%
==========================================
Files 306 306
Lines 9985 9987 +2
Branches 1440 1440
==========================================
+ Hits 7262 7265 +3
Misses 2153 2153
+ Partials 570 569 -1
|
bidetofevil
force-pushed
the
hho/internal-interface
branch
from
October 24, 2023 21:47
a5fae6f
to
924a37b
Compare
bidetofevil
changed the title
Add interface for an intra-SDK, cross-module, internal API
Add getSdkCurrentTime to internal interface
Oct 25, 2023
bidetofevil
requested review from
fractalwrench,
fnewberg and
a team
as code owners
October 25, 2023 16:24
lucaslabari
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add the method to the internal interface so the OkHttp module or code that can only access the static
Embrace
instance can use the same time as the core SDK.Testing
Release Notes
Add unit and integration tests