Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getSdkCurrentTime to internal interface #8

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Oct 17, 2023

Goal

Add the method to the internal interface so the OkHttp module or code that can only access the static Embrace instance can use the same time as the core SDK.

Testing

Release Notes

Add unit and integration tests

Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #8 (924a37b) into master (009b076) will increase coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   72.72%   72.74%   +0.01%     
==========================================
  Files         306      306              
  Lines        9985     9987       +2     
  Branches     1440     1440              
==========================================
+ Hits         7262     7265       +3     
  Misses       2153     2153              
+ Partials      570      569       -1     
Files Coverage Δ
...ava/io/embrace/android/embracesdk/EmbraceImpl.java 47.08% <ø> (ø)
...android/embracesdk/EmbraceInternalInterfaceImpl.kt 92.20% <100.00%> (+0.10%) ⬆️
...race/android/embracesdk/InternalInterfaceModule.kt 100.00% <100.00%> (ø)
...id/embracesdk/internal/EmbraceInternalInterface.kt 35.71% <100.00%> (+4.94%) ⬆️

... and 1 file with indirect coverage changes

@bidetofevil bidetofevil force-pushed the hho/internal-interface branch from a5fae6f to 924a37b Compare October 24, 2023 21:47
@bidetofevil bidetofevil changed the title Add interface for an intra-SDK, cross-module, internal API Add getSdkCurrentTime to internal interface Oct 25, 2023
@bidetofevil bidetofevil marked this pull request as ready for review October 25, 2023 16:24
Copy link
Contributor

@lucaslabari lucaslabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Oct 25, 2023

Merge activity

@bidetofevil bidetofevil merged commit 1e103be into master Oct 25, 2023
4 checks passed
@bidetofevil bidetofevil deleted the hho/internal-interface branch October 25, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants