Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter lamdba parameter to be last #885

Merged
merged 1 commit into from
May 28, 2024
Merged

Alter lamdba parameter to be last #885

merged 1 commit into from
May 28, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Alters the lambda parameter to be last to be more idiomatic Kotlin

@fractalwrench fractalwrench requested a review from a team as a code owner May 24, 2024 12:28
@fractalwrench fractalwrench changed the base branch from master to alter-package-name May 24, 2024 12:31
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (af40d9a) to head (8e44fc3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   80.95%   80.93%   -0.02%     
==========================================
  Files         435      435              
  Lines       11613    11613              
  Branches     1764     1764              
==========================================
- Hits         9401     9399       -2     
- Misses       1436     1437       +1     
- Partials      776      777       +1     
Files Coverage Δ
...e/android/embracesdk/arch/destination/LogWriter.kt 100.00% <100.00%> (ø)
...droid/embracesdk/arch/destination/LogWriterImpl.kt 94.73% <ø> (ø)
...ndroid/embracesdk/capture/aei/AeiDataSourceImpl.kt 85.36% <100.00%> (ø)
...dk/network/logging/NetworkCaptureDataSourceImpl.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Base automatically changed from alter-package-name to master May 24, 2024 14:49
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit 53a33ef into master May 28, 2024
4 checks passed
@fractalwrench fractalwrench deleted the alter-func-sig branch May 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants