Add otel log data source for internal errors #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
alter-func-sig
branch
from
d655ad7 to
c74d8cc
Compare
fractalwrench
force-pushed
the
initial-otel-internal-errors
branch
from
33313c5 to
d4e6744
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #886 +/- ##
==========================================
- Coverage 81.00% 80.86% -0.15%
==========================================
Files 440 441 +1
Lines 11745 11752 +7
Branches 1795 1794 -1
==========================================
- Hits 9514 9503 -11
- Misses 1440 1456 +16
- Partials 791 793 +2
|
fractalwrench
force-pushed
the
alter-func-sig
branch
from
c74d8cc to
8e44fc3
Compare
fractalwrench
force-pushed
the
initial-otel-internal-errors
branch
from
d4e6744 to
5f5f8e8
Compare
bidetofevil
reviewed
May 29, 2024
| @@ -57,6 +57,8 @@ internal sealed class EmbType(type: String, subtype: String?) : TelemetryType { | |||
|
|
|||
| internal object Exception : System("exception") | |||
|
|
|||
| internal object InternalError : System("internal") | |||
There was a problem hiding this comment.
why not a name that indicates that it's some sort of error or warning?
There was a problem hiding this comment.
This is what was suggested with Pablo/Austin
There was a problem hiding this comment.
I guess these don't have to something bad. But there's a pedanticness rising in me that says this should be a noun.........
I'll suck it up lol
bidetofevil
approved these changes
May 29, 2024
bidetofevil
reviewed
May 29, 2024
| alterSessionSpan(NoInputValidation) { | ||
| this.addLog(throwable, true) { | ||
| val schemaType = SchemaType.InternalError(throwable) | ||
| LogEventData(schemaType, Severity.ERROR, "") |
There was a problem hiding this comment.
Should be make these logs private so they are not exported to the generic exporter?
There was a problem hiding this comment.
I thought that supplying true to addLog was enough to do that?
There was a problem hiding this comment.
Oh sweet you're right!
fractalwrench
force-pushed
the
initial-otel-internal-errors
branch
5 times, most recently
from
7a32051 to
1c4518b
Compare
fractalwrench
force-pushed
the
initial-otel-internal-errors
branch
from
1c4518b to
6ee1288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Implements our internal telemetry using OTel logs. This is not hooked up to data capture yet - that will be done in a separate PR.
Testing
Added unit tests.