Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace internal errors with OTel logs #887

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Replaces internal errors with OTel logs.

Testing

Relied on existing test coverage.

@fractalwrench fractalwrench requested a review from a team as a code owner May 24, 2024 13:07
@fractalwrench fractalwrench force-pushed the internal-error-otel branch from 1919cf1 to a7c9038 Compare May 24, 2024 14:06
@fractalwrench fractalwrench force-pushed the initial-otel-internal-errors branch from 33313c5 to d4e6744 Compare May 24, 2024 15:18
@fractalwrench fractalwrench force-pushed the internal-error-otel branch from a7c9038 to e56cf47 Compare May 24, 2024 15:18
@fractalwrench fractalwrench force-pushed the initial-otel-internal-errors branch from d4e6744 to 5f5f8e8 Compare May 28, 2024 10:17
@fractalwrench fractalwrench force-pushed the internal-error-otel branch from e56cf47 to 2adb05f Compare May 28, 2024 10:20
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench force-pushed the initial-otel-internal-errors branch from 5f5f8e8 to c303b95 Compare June 6, 2024 10:35
@fractalwrench fractalwrench force-pushed the internal-error-otel branch from 2adb05f to 139b12d Compare June 6, 2024 10:37
@fractalwrench fractalwrench force-pushed the initial-otel-internal-errors branch from c303b95 to 383b730 Compare June 10, 2024 13:18
@fractalwrench fractalwrench merged commit 6e944e9 into initial-otel-internal-errors Jun 10, 2024
1 check failed
@fractalwrench fractalwrench deleted the internal-error-otel branch June 10, 2024 13:18
fractalwrench added a commit that referenced this pull request Jun 10, 2024
Replace internal errors with OTel logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants