Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version field #890

Merged
merged 1 commit into from
May 30, 2024
Merged

Remove version field #890

merged 1 commit into from
May 30, 2024

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the legacy version field. This is targeting an integration branch so won't be merged down to master just yet.

Testing

Relied on existing test coverage

@fractalwrench fractalwrench requested a review from a team as a code owner May 28, 2024 12:19
@fractalwrench fractalwrench changed the title refactor: remove version field Remove version field May 28, 2024
@fractalwrench fractalwrench requested a review from bidetofevil May 29, 2024 10:47
@bidetofevil Graphite App
Copy link
Collaborator

LGTM

bidetofevil
bidetofevil approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from remove-user-info to integration/v2-migration May 30, 2024 07:56
@fractalwrench fractalwrench merged commit f6d2f03 into integration/v2-migration May 30, 2024
3 checks passed
@fractalwrench fractalwrench deleted the remove-version-field branch May 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidetofevil bidetofevil bidetofevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @bidetofevil