Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove app info field #891

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes the legacy app info field. This is targeting an integration branch so won't be merged down to master just yet.

Testing

Relied on existing test coverage

@fractalwrench fractalwrench requested a review from a team as a code owner May 28, 2024 13:21
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (319b76d) to head (1d17239).

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           remove-version-field     #891      +/-   ##
========================================================
+ Coverage                 80.89%   80.93%   +0.03%     
========================================================
  Files                       435      435              
  Lines                     11613    11610       -3     
  Branches                   1766     1766              
========================================================
+ Hits                       9394     9396       +2     
+ Misses                     1439     1435       -4     
+ Partials                    780      779       -1     
Files Coverage Δ
...brace/android/embracesdk/payload/SessionMessage.kt 100.00% <ø> (ø)
...acesdk/session/message/V1PayloadMessageCollator.kt 96.55% <ø> (-0.04%) ⬇️
...acesdk/session/message/V2PayloadMessageCollator.kt 83.50% <ø> (-0.17%) ⬇️

... and 2 files with indirect coverage changes

@fractalwrench fractalwrench requested a review from bidetofevil May 29, 2024 10:47
Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from remove-version-field to integration/v2-migration May 30, 2024 07:56
@fractalwrench fractalwrench merged commit d04fab4 into integration/v2-migration May 30, 2024
3 checks passed
@fractalwrench fractalwrench deleted the remove-app-info-field branch May 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants