Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new sdk time direcctly and indirectly for timetamps sent in SDK #9

Merged
merged 3 commits into from
Oct 25, 2023

Add tests to validate time and change impl to make that possible

9a99cd8
Select commit
Loading
Failed to load commit list.
Merged

Use new sdk time direcctly and indirectly for timetamps sent in SDK #9

Add tests to validate time and change impl to make that possible
9a99cd8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 25, 2023 in 0s

29.16% of diff hit (target 72.74%)

View this Pull Request on Codecov

29.16% of diff hit (target 72.74%)

Annotations

Check warning on line 240 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L240 

Added line #L240 was not covered by tests

Check warning on line 302 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L302 

Added line #L302 was not covered by tests

Check warning on line 311 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L311 

Added line #L311 was not covered by tests

Check warning on line 321 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L321 

Added line #L321 was not covered by tests

Check warning on line 329 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L328-L329 

Added lines #L328 - L329 were not covered by tests

Check warning on line 339 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L338-L339 

Added lines #L338 - L339 were not covered by tests

Check warning on line 350 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L350 

Added line #L350 was not covered by tests

Check warning on line 352 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L352 

Added line #L352 was not covered by tests

Check warning on line 374 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L374 

Added line #L374 was not covered by tests

Check warning on line 486 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/network/http/EmbraceUrlConnectionOverride.java#L486 

Added line #L486 was not covered by tests

Check warning on line 80 in embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/samples/EmbraceCrashSamples.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

embrace-android-sdk/src/main/java/io/embrace/android/embracesdk/samples/EmbraceCrashSamples.kt#L79-L80 

Added lines #L79 - L80 were not covered by tests
View more details on Codecov