Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method from DeliveryService. #90

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

lucaslabari
Copy link
Contributor

Goal

  • Removed sendEvent() method from DeliveryService because it was not being called.
  • Renamed sendLogs() to sendLog()

Testing

Updated unit tests.

@lucaslabari lucaslabari requested a review from a team as a code owner November 17, 2023 14:55
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #90 (37ea394) into master (7b2e011) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   76.02%   76.02%           
=======================================
  Files         314      314           
  Lines       10076    10075    -1     
  Branches     1457     1457           
=======================================
  Hits         7660     7660           
+ Misses       1827     1826    -1     
  Partials      589      589           
Files Coverage Δ
...ce/android/embracesdk/event/EmbraceRemoteLogger.kt 93.50% <100.00%> (ø)
...mbracesdk/comms/delivery/EmbraceDeliveryService.kt 62.09% <0.00%> (+0.49%) ⬆️

Copy link
Collaborator

@bidetofevil bidetofevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Digging deeper into the code, I wonder if we can remove some of these methods in DeliveryService whose implementation is just calling ApiService - and just have the the caller consume the ApiService directly?

@lucaslabari
Copy link
Contributor Author

LGTM. Digging deeper into the code, I wonder if we can remove some of these methods in DeliveryService whose implementation is just calling ApiService - and just have the the caller consume the ApiService directly?

Yeap, that would be a good think to do so we remove the deliveryService from being the middleman.

@lucaslabari lucaslabari merged commit 7a61b70 into master Nov 17, 2023
3 of 4 checks passed
@lucaslabari lucaslabari deleted the lucas/remove_unused_method branch November 17, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants