Remove the population of emb.type from schema attributes

[bidetofevil]

Goal

Remove the population emb.type via an object's schema attributes. Instead, do it when the schema is being processed, which is already being done for spans so that it can't be overwritten by users who have a reference to the span object.

Correspondingly, changed where it's populated for logs and span events on the session span as well, which are the two other places that reads schema attributes.

Testing

Fixed unit tests looking at DataSource *Data objects' attributes for the emb.type, and instead look at the schema itself to check right value. Integration test correctly check the attributes and therefore are still passing.

[bidetofevil]

• Remove the population of emb.type from schema attributes #931 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (bca00d2) to head (137875c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
- Coverage   80.96%   80.93%   -0.04%     
==========================================
  Files         438      438              
  Lines       11712    11714       +2     
  Branches     1790     1790              
==========================================
- Hits         9483     9481       -2     
- Misses       1442     1446       +4     
  Partials      787      787              

Files	Coverage Δ
...droid/embracesdk/arch/destination/LogWriterImpl.kt	95.23% <100.00%> (+0.50%)	⬆️
...brace/android/embracesdk/arch/schema/SchemaType.kt	80.10% <100.00%> (ø)
...mbracesdk/internal/spans/CurrentSessionSpanImpl.kt	88.23% <100.00%> (ø)

... and 1 file with indirect coverage changes

[fractalwrench]

LGTM