EMBR-4229 integration tests for using the otel navigation library #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmunz
commented
Sep 27, 2024
| setError( | ||
| "The Embrace SDK must be started to use the TracerProvider, please invoke `initialize` from `@embrace-io/react-native`.", | ||
| ); | ||
| setIsError(true); | ||
| } else if (!tracerProvider) { |
There was a problem hiding this comment.
@facostaembrace I couldn't reproduce seeing the view span recorded twice after making this change so I'll assume for now it was due to accidentally instantiating this provider multiple times
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-react-native-tracer-provider #158 +/- ##
========================================================================
+ Coverage 80.33% 80.36% +0.02%
========================================================================
Files 36 36
Lines 1536 1538 +2
Branches 140 142 +2
========================================================================
+ Hits 1234 1236 +2
Misses 301 301
Partials 1 1
|
jpmunz
commented
Sep 27, 2024
| } from "../helpers/span"; | ||
|
|
||
| describe("Navigation", () => { | ||
| it("should record the initially rendered screen", async () => { |
There was a problem hiding this comment.
@facostaembrace I was seeing this passing on both Android and iOS which I believe addresses the concern of not capturing the first render, unless there is another test you think could be added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration tests for using the otel navigation instrumentation library with our tracer provider.
Follow-ups outside of this PR:
refto the NavigationTracker exposed by the library: https://www.notion.so/embraceio/Type-error-when-passing-ref-to-instrumentation-react-native-navigation-NavigationTracker-10e7e3c99852805cbaa4deb81ef195c5?pvs=4