Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GJS to the default addon blueprint #159

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Add GJS to the default addon blueprint #159

merged 3 commits into from
Aug 9, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented Jul 21, 2023

Edit: this is now almost ready 🎉 CI should show that prettier isn't working for GJS files and that should be our last step before we can make this the default 💪

@mansona mansona force-pushed the add-gjs branch 2 times, most recently from 2014300 to cdbe7f9 Compare August 2, 2023 15:13
@mansona mansona mentioned this pull request Aug 2, 2023
@mansona mansona marked this pull request as ready for review August 9, 2023 16:11
@@ -37,13 +34,16 @@ export default {
// By default, this will load the actual babel config from the file
// babel.config.json.
babel({
extensions,
extensions: ['.js', '.gjs'<% if (typescript) { %>, '.ts', '.gts'<% } %>],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!!

Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants