Remove pnpm version from pnpm/action-setup #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickschot
force-pushed
the
fix/pnpm-ci-template
branch
from
6ae9f0b to
934503c
Compare
NullVoxPopuli
approved these changes
Feb 22, 2025
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated a fresh --pnpm version of the blueprint and ran into an issue with CI not liking that a version for
pnpmwas still specified while we also havepackageManagerset preventing CI from running at all.They were out of sync as well (v8 in CI, v10 in package.json), but apparently it's no longer needed to specify a version in the CI config if
packageManageris set in package.json.Example CI error: https://github.com/nickschot/macros-reproduction/actions/runs/13472870355
Docs for the action: https://github.com/pnpm/action-setup?tab=readme-ov-file#version