Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/NullVoxPopuli/vitest-blueprint
This is for projects where they don't need a test app or maybe have node things to test outside of the test app.
Ember historically hasn't made a decision on node-testing convention, but I think this is pretty easy (no other node testing tool comes close to the ease of use here (at least that's been released in 3+ months ago)).
For example,
@ember/string
's v2-addon-conversion PR the ember app has been fully removed in favor of node-only tests (which vitest is good at (minimal config, works with ESM and TS out of the box))).This is because the addon is really just a utility library with some functions and doesn't do anything ember-specific.
So v2 addons become a blueprint for rollup libraries, and not anything just ember specific.