Fix compatibility with ember-cli-babel@7.26+ #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
fix-with-new-babel
branch
from
a1ffedd to
b014e3f
Compare
rwjblue
force-pushed
the
fix-with-new-babel
branch
from
b014e3f to
44a6fe7
Compare
ember-cli-babel@7.24 fixed a bug where the `buildBabelOptions` result included a number of non-babel specific properties. Unfortunately, while we were explicitly working around that bug (the `delete`'s in the snippet here) but we **also** ended up relying on it with the usage of `filterExtensions` property. In order to make it possible for ember-auto-import to have a path forward, ember-cli-babel@7.26.0 introduces a new public API to get a list of the supported extensions (`babelAddon.getSupportedExtensions`). This PR uses the presence of the `getSupportedExtensions` function to decide if it needs to clear the abnormal properties or not, and fixes usage of ember-auto-import along with ember-cli-babel@7.26+.
rwjblue
force-pushed
the
fix-with-new-babel
branch
from
44a6fe7 to
3d65928
Compare
rwjblue
commented
Mar 18, 2021
| let babelOptions, extensions; | ||
|
|
||
| if (typeof babelAddon.getSupportedExtensions === 'function') { | ||
| babelOptions = babelAddon.buildBabelOptions('babel', options); |
There was a problem hiding this comment.
I added this new signature so that I could make the default invocation without arguments (or options) passed return the broccoli-babel-transpiler style options.
|
Now that the test updates have landed, we can probably just update the ember-cli-babel version in |
|
This is breaking ember-auto-import 2.0.0-beta.1 due to emberjs/ember-cli-babel#401. I'm going to revert it and rely on the backward compatible call signature instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-cli-babel@7.24 fixed a bug where the
buildBabelOptionsresult included a number of non-babel specific properties (reported in emberjs/ember-cli-babel#227). Unfortunately, while we were explicitly working around that bug (thedelete's in the snippet here) but we also ended up relying on it with the usage offilterExtensionsproperty.In order to make it possible for ember-auto-import to have a path forward, ember-cli-babel@7.26.0 introduces a new public API to get a list of the supported extensions (
babelAddon.getSupportedExtensions).This PR uses the presence of the
getSupportedExtensionsfunction to decide if it needs to clear the abnormal properties or not, and fixes usage of ember-auto-import along with ember-cli-babel@7.26+.Fixes #359
Fixes emberjs/ember-cli-babel#389