feat(app/addons public-assets): re-add the blocks that creates assets…

… on disk so they can be used in build mode

packages/compat/src/compat-app-builder.ts

@@ -20,6 +20,7 @@ import {
   Resolver,
   locateEmbroiderWorkingDir,
 } from '@embroider/core';
+import walkSync from 'walk-sync';
 import { resolve as resolvePath, posix } from 'path';
 import type { JSDOM } from 'jsdom';
 import type Options from './options';
@@ -89,6 +90,29 @@ export class CompatAppBuilder {
   private extractAssets(treePaths: OutputPaths<TreeNames>): Asset[] {
     let assets: Asset[] = [];
 
+    // Everything in our traditional public tree is an on-disk asset
+    // In dev mode, Vite middleware can return the public assets, but
+    // in build mode, they still need to be copied from rewritten app
+    // to dist
+    const isBuildMode = false; // TODO: how to know?
+    if (isBuildMode) {
+      if (treePaths.publicTree) {
+        walkSync
+          .entries(treePaths.publicTree, {
+            directories: false,
+          })
+          .forEach(entry => {
+            assets.push({
+              kind: 'on-disk',
+              relativePath: entry.relativePath,
+              sourcePath: entry.fullPath,
+              mtime: entry.mtime as unknown as number, // https://github.com/joliss/node-walk-sync/pull/38
+              size: entry.size,
+            });
+          });
+      }
+    }
+
     // ember-cli traditionally outputs a dummy testem.js file to prevent
     // spurious errors when running tests under "ember s".
     if (this.compatApp.shouldBuildTests) {
@@ -886,6 +910,28 @@ export class CompatAppBuilder {
     // first gather all the assets out of addons
     let assets: Asset[] = [];
 
+    // In dev mode, Vite middleware can return the public assets, but
+    // in build mode, they still need to be copied from rewritten app
+    // to dist
+    const isBuildMode = false; // TODO: how to know?
+    if (isBuildMode) {
+      for (let pkg of this.allActiveAddons) {
+        if (pkg.meta['public-assets']) {
+          for (let [filename, appRelativeURL] of Object.entries(pkg.meta['public-assets'] || {})) {
+            let sourcePath = resolvePath(pkg.root, filename);
+            let stats = statSync(sourcePath);
+            assets.push({
+              kind: 'on-disk',
+              sourcePath,
+              relativePath: appRelativeURL,
+              mtime: stats.mtimeMs,
+              size: stats.size,
+            });
+          }
+        }
+      }
+    }
+
     if (this.activeFastboot) {
       const source = `
       (function(){