Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version check in dependencySatisfies #1051

Closed
simonihmig opened this issue Dec 13, 2021 · 2 comments
Closed

Wrong version check in dependencySatisfies #1051

simonihmig opened this issue Dec 13, 2021 · 2 comments

Comments

@simonihmig
Copy link
Collaborator

It seems dependencySatisfies needs a similar fix as as emberjs/ember-cli-babel#396 and ember-cli/ember-cli-htmlbars#741.

In a monorepo with one app running on 3.26 and others on 3.28, this check in @embroider/util returns true, as both @embroider/util and ember-source are in the hoisted main node_modules, while the app in question has its own version of Ember in its local node_modules.

@ef4
Copy link
Contributor

ef4 commented Dec 20, 2021

I think this was probably fixed by #1053

@embroider/util needed peerDep on ember-source in order to guarantee that it will resolve the app's copy.

@ef4
Copy link
Contributor

ef4 commented Dec 20, 2021

This is a general thing -- dependencySatisfies makes the most sense with peerDeps (which can also be optional peerDeps). Because your own dependencies are generally known, and non-dependencies can't be reliably resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants