Fix incorrect ember-source version check #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this bug in a monorepo setup with multiple apps, where one app was using an older version (3.26, so needed the modules API polyfill) while the others were on 3.28. With most dependencies being hoisted in the central `/node_modules`, for any addon that depends on ember-cli-htmlbars it would find the wrong ember-source package, namely `/node_modules/ember-source` instead of `apps/foo-app/node_modules/ember-source` (the correct 3.26 version). Fixes ember-cli#687
nickschot
added a commit
to nickschot/ember-mobile-menu
that referenced
this pull request
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug in a monorepo setup with multiple apps, where one app was using an older version (3.26, so needed the modules API polyfill) while the others were on 3.28. With most dependencies being hoisted in the central
/node_modules, for any addon that depends on ember-cli-htmlbars it would find the wrong ember-source package, namely/node_modules/ember-source(3.28) instead ofapps/foo-app/node_modules/ember-source(the correct 3.26 version).Fixes #687