Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's fix the punycode deprecation #2060

Open
1 of 5 tasks
NullVoxPopuli opened this issue Jul 27, 2024 · 0 comments
Open
1 of 5 tasks

Let's fix the punycode deprecation #2060

NullVoxPopuli opened this issue Jul 27, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Jul 27, 2024

tl;dr:

investigate the following


This is what needs upgraded / PR'd:

❯ pnpm dlx punycode-detector
Packages: +1
+
Progress: resolved 1, reused 1, downloaded 0, added 1, done
There are 12 imports/requires of 'punycode' : The node builtin (which is deprecated) and not the 'punycode/' userland package.
Set(12) {
  'node_modules/.pnpm/markdown-it@12.3.2/node_modules/markdown-it/lib/index.js',
  'node_modules/.pnpm/markdown-it@13.0.2/node_modules/markdown-it/lib/index.js',
  'node_modules/.pnpm/markdown-it@8.4.2/node_modules/markdown-it/lib/index.js',
  'node_modules/.pnpm/markdown-it@8.4.2/node_modules/markdown-it/dist/markdown-it.js',
  'node_modules/.pnpm/normalize-url@2.0.1/node_modules/normalize-url/index.js',
  'node_modules/.pnpm/psl@1.9.0/node_modules/psl/index.js',
  'node_modules/.pnpm/psl@1.9.0/node_modules/psl/dist/psl.js',
  'node_modules/.pnpm/whatwg-url@5.0.0/node_modules/whatwg-url/lib/url-state-machine.js',
  'node_modules/.pnpm/tr46@2.1.0/node_modules/tr46/index.js',
  'node_modules/.pnpm/whatwg-url@8.7.0/node_modules/whatwg-url/dist/url-state-machine.js',
  'node_modules/.pnpm/tr46@3.0.0/node_modules/tr46/index.js',
  'node_modules/.pnpm/tr46@0.0.3/node_modules/tr46/index.js'
}

Where do these come from?

❯ pnpm why $DEP_NAME --production -r

Markdown-it

Legend: production dependency, optional only, dev only

@embroider/test-support@0.36.0 /home/nvp/Development/OpenSource/emberjs/embroider/test-packages/support

dependencies:
ember-cli 3.28.6
├── markdown-it 12.3.2
└─┬ markdown-it-terminal 0.2.1
  └── markdown-it 8.4.2

@embroider/test-scenarios@0.0.5 /home/nvp/Development/OpenSource/emberjs/embroider/tests/scenarios

dependencies:
@embroider/test-support link:../../test-packages/support
└─┬ ember-cli 3.28.6
  ├── markdown-it 12.3.2
  └─┬ markdown-it-terminal 0.2.1
    └── markdown-it 8.4.2

normalize-url

does not occur in production dependencies, but is in dev deps

Legend: production dependency, optional only, dev only

/home/nvp/Development/OpenSource/emberjs/embroider

devDependencies:
release-plan 0.9.0
└─┬ latest-version 5.1.0
  └─┬ package-json 6.5.0
    └─┬ got 9.6.0
      └─┬ cacheable-request 6.1.0
        └── normalize-url 4.5.1

@embroider/sample-transforms@0.0.0 /home/nvp/Development/OpenSource/emberjs/embroider/test-packages/sample-transforms

devDependencies:
ember-source-channel-url 1.2.0
└─┬ got 8.3.2
  └─┬ cacheable-request 2.1.4
    └── normalize-url 2.0.1

addon-template@0.0.0 /home/nvp/Development/OpenSource/emberjs/embroider/tests/addon-template

devDependencies:
ember-try 2.0.0
└─┬ ember-try-config 4.0.0
  └─┬ package-json 6.5.0
    └─┬ got 9.6.0
      └─┬ cacheable-request 6.1.0
        └── normalize-url 4.5.1

psl

Legend: production dependency, optional only, dev only

@embroider/addon-dev@5.0.0 /home/nvp/Development/OpenSource/emberjs/embroider/packages/addon-dev

dependencies:
@embroider/core link:../core
└─┬ jsdom 16.7.0
  └─┬ tough-cookie 4.1.4
    └── psl 1.9.0

@embroider/compat@3.5.6 /home/nvp/Development/OpenSource/emberjs/embroider/packages/compat

dependencies:
jsdom 16.7.0
└─┬ tough-cookie 4.1.4
  └── psl 1.9.0

@embroider/core@3.4.14 /home/nvp/Development/OpenSource/emberjs/embroider/packages/core

dependencies:
jsdom 16.7.0
└─┬ tough-cookie 4.1.4
  └── psl 1.9.0

@embroider/vite@0.2.0 /home/nvp/Development/OpenSource/emberjs/embroider/packages/vite

dependencies:
jsdom 16.7.0
└─┬ tough-cookie 4.1.4
  └── psl 1.9.0

@embroider/webpack@4.0.4 /home/nvp/Development/OpenSource/emberjs/embroider/packages/webpack

dependencies:
jsdom 16.7.0
└─┬ tough-cookie 4.1.4
  └── psl 1.9.0

@embroider/test-scenarios@0.0.5 /home/nvp/Development/OpenSource/emberjs/embroider/tests/scenarios

dependencies:
@embroider/addon-dev link:../../packages/addon-dev
└─┬ @embroider/core link:../../packages/core
  └─┬ jsdom 16.7.0
    └─┬ tough-cookie 4.1.4
      └── psl 1.9.0
@embroider/compat link:../../packages/compat
└─┬ jsdom 16.7.0
  └─┬ tough-cookie 4.1.4
    └── psl 1.9.0
@embroider/core link:../../packages/core
└─┬ jsdom 16.7.0
  └─┬ tough-cookie 4.1.4
    └── psl 1.9.0
@embroider/webpack link:../../packages/webpack
└─┬ jsdom 16.7.0
  └─┬ tough-cookie 4.1.4
    └── psl 1.9.0
fastboot 4.1.4
└─┬ jsdom 19.0.0
  └─┬ tough-cookie 4.1.4
    └── psl 1.9.0
jsdom 16.7.0
└─┬ tough-cookie 4.1.4
  └── psl 1.9.0

whatwg-url

Legend: production dependency, optional only, dev only

@embroider/addon-dev@5.0.0 /home/nvp/Development/OpenSource/emberjs/embroider/packages/addon-dev

dependencies:
@embroider/core link:../core
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └── whatwg-url 8.7.0
  └── whatwg-url 8.7.0

@embroider/compat@3.5.6 /home/nvp/Development/OpenSource/emberjs/embroider/packages/compat

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └── whatwg-url 8.7.0
└── whatwg-url 8.7.0

@embroider/core@3.4.14 /home/nvp/Development/OpenSource/emberjs/embroider/packages/core

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └── whatwg-url 8.7.0
└── whatwg-url 8.7.0

@embroider/vite@0.2.0 /home/nvp/Development/OpenSource/emberjs/embroider/packages/vite

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └── whatwg-url 8.7.0
└── whatwg-url 8.7.0

@embroider/webpack@4.0.4 /home/nvp/Development/OpenSource/emberjs/embroider/packages/webpack

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └── whatwg-url 8.7.0
└── whatwg-url 8.7.0

@embroider/test-support@0.36.0 /home/nvp/Development/OpenSource/emberjs/embroider/test-packages/support

dependencies:
ember-cli 3.28.6
└─┬ ember-source-channel-url 3.0.0
  └─┬ node-fetch 2.7.0
    └── whatwg-url 5.0.0

@embroider/test-scenarios@0.0.5 /home/nvp/Development/OpenSource/emberjs/embroider/tests/scenarios

dependencies:
@embroider/addon-dev link:../../packages/addon-dev
└─┬ @embroider/core link:../../packages/core
  └─┬ jsdom 16.7.0
    ├─┬ data-urls 2.0.0
    │ └── whatwg-url 8.7.0
    └── whatwg-url 8.7.0
@embroider/compat link:../../packages/compat
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └── whatwg-url 8.7.0
  └── whatwg-url 8.7.0
@embroider/core link:../../packages/core
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └── whatwg-url 8.7.0
  └── whatwg-url 8.7.0
@embroider/test-support link:../../test-packages/support
└─┬ ember-cli 3.28.6
  └─┬ ember-source-channel-url 3.0.0
    └─┬ node-fetch 2.7.0
      └── whatwg-url 5.0.0
@embroider/webpack link:../../packages/webpack
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └── whatwg-url 8.7.0
  └── whatwg-url 8.7.0
fastboot 4.1.4
└─┬ jsdom 19.0.0
  └─┬ data-urls 3.0.2
    └── whatwg-url 11.0.0

tr46

Legend: production dependency, optional only, dev only

@embroider/addon-dev@5.0.0 /home/nvp/Development/OpenSource/emberjs/embroider/packages/addon-dev

dependencies:
@embroider/core link:../core
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └─┬ whatwg-url 8.7.0
  │   └── tr46 2.1.0
  └─┬ whatwg-url 8.7.0
    └── tr46 2.1.0

@embroider/compat@3.5.6 /home/nvp/Development/OpenSource/emberjs/embroider/packages/compat

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └─┬ whatwg-url 8.7.0
│   └── tr46 2.1.0
└─┬ whatwg-url 8.7.0
  └── tr46 2.1.0

@embroider/core@3.4.14 /home/nvp/Development/OpenSource/emberjs/embroider/packages/core

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └─┬ whatwg-url 8.7.0
│   └── tr46 2.1.0
└─┬ whatwg-url 8.7.0
  └── tr46 2.1.0

@embroider/vite@0.2.0 /home/nvp/Development/OpenSource/emberjs/embroider/packages/vite

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └─┬ whatwg-url 8.7.0
│   └── tr46 2.1.0
└─┬ whatwg-url 8.7.0
  └── tr46 2.1.0

@embroider/webpack@4.0.4 /home/nvp/Development/OpenSource/emberjs/embroider/packages/webpack

dependencies:
jsdom 16.7.0
├─┬ data-urls 2.0.0
│ └─┬ whatwg-url 8.7.0
│   └── tr46 2.1.0
└─┬ whatwg-url 8.7.0
  └── tr46 2.1.0

@embroider/test-support@0.36.0 /home/nvp/Development/OpenSource/emberjs/embroider/test-packages/support

dependencies:
ember-cli 3.28.6
└─┬ ember-source-channel-url 3.0.0
  └─┬ node-fetch 2.7.0
    └─┬ whatwg-url 5.0.0
      └── tr46 0.0.3

@embroider/test-scenarios@0.0.5 /home/nvp/Development/OpenSource/emberjs/embroider/tests/scenarios

dependencies:
@embroider/addon-dev link:../../packages/addon-dev
└─┬ @embroider/core link:../../packages/core
  └─┬ jsdom 16.7.0
    ├─┬ data-urls 2.0.0
    │ └─┬ whatwg-url 8.7.0
    │   └── tr46 2.1.0
    └─┬ whatwg-url 8.7.0
      └── tr46 2.1.0
@embroider/compat link:../../packages/compat
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └─┬ whatwg-url 8.7.0
  │   └── tr46 2.1.0
  └─┬ whatwg-url 8.7.0
    └── tr46 2.1.0
@embroider/core link:../../packages/core
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └─┬ whatwg-url 8.7.0
  │   └── tr46 2.1.0
  └─┬ whatwg-url 8.7.0
    └── tr46 2.1.0
@embroider/test-support link:../../test-packages/support
└─┬ ember-cli 3.28.6
  └─┬ ember-source-channel-url 3.0.0
    └─┬ node-fetch 2.7.0
      └─┬ whatwg-url 5.0.0
        └── tr46 0.0.3
@embroider/webpack link:../../packages/webpack
└─┬ jsdom 16.7.0
  ├─┬ data-urls 2.0.0
  │ └─┬ whatwg-url 8.7.0
  │   └── tr46 2.1.0
  └─┬ whatwg-url 8.7.0
    └── tr46 2.1.0
fastboot 4.1.4
└─┬ jsdom 19.0.0
  └─┬ data-urls 3.0.2
    └─┬ whatwg-url 11.0.0
      └── tr46 3.0.0

@NullVoxPopuli NullVoxPopuli added the good first issue Good for newcomers label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant