Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 Warning #323

Closed
ackava opened this issue Jul 5, 2024 · 12 comments
Closed

Node 22 Warning #323

ackava opened this issue Jul 5, 2024 · 12 comments
Assignees

Comments

@ackava
Copy link

ackava commented Jul 5, 2024

DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.

As per punnycode , https://www.npmjs.com/package/punycode , require("punnycode") should be replaced with require("punnycode/")

@BenjaminAster
Copy link

The issue has been fixed already in #298, but no new version of this package has been published since 2022. @lupomontero could you please update the version in package.json to 1.9.1 and publish to npm? Thanks a lot in advance! (This is relatively serious since jsdom indirectly depends on psl through the tough-cookie package and thus jsdom users currently get deprecation warnings.)

@ackava
Copy link
Author

ackava commented Jul 7, 2024

@BenjaminAster There is no 1.9.1 in npm, https://www.npmjs.com/package/psl?activeTab=versions history shows last published version was 1.9.0.

@BenjaminAster
Copy link

@ackava Sorry if I was unclear in my wording – this is exactly what I meant; @lupomontero should publish a new version to npm (1.9.0 is the current version, so 1.9.1 or possibly 1.10.0 would be the next one).

@ackava
Copy link
Author

ackava commented Jul 8, 2024

@BenjaminAster Sorry, I thought you were the author. I checked the builds and last build has failed and I hope authors publish. However I checked tough-cookie, they have pre release build in which they have removed psl dependency.

@damiensawyer
Copy link

Thanks for that @BenjaminAster.
If anyone finds this you can force the temporary override with the pre-release tough-cookie with

{
"name": "your-project-name",
"version": "1.0.0",
"scripts": {
"start": "node index.js"
},
"devDependencies": {
"@vitest/ui": "2.0.4",
"vitest": "2.0.4"
},
"pnpm": {
"overrides": {
"tough-cookie": "5.0.0-rc.4"
}
}
}

... then pnpm install.

@NullVoxPopuli
Copy link

just ran in to this deprecation -- would love to see a new release

@BlackCat1397
Copy link

Up

@jycouet
Copy link

jycouet commented Sep 13, 2024

Yeahhh, would love it too

@mo
Copy link

mo commented Sep 18, 2024

node 22 is very soon LTS... would be really nice with a new release of psl that doesn't use punycode

TooTallNate pushed a commit to vercel/vercel that referenced this issue Sep 27, 2024
`psl` is one of the deps causing the `punycode` deprecation warning on
Node 22. [The newest version includes the deprecation
warning](lupomontero/psl#323), so we can't
just update `psl`.

Inspired by salesforce/tough-cookie#346.
@lupomontero lupomontero self-assigned this Nov 7, 2024
@lupomontero
Copy link
Owner

Hi there, many apologies for taking so long to address this... I have just released a new version that should include a fix for this issue: https://github.com/lupomontero/psl/releases/tag/v1.10.0

@NullVoxPopuli
Copy link

thank you!

@mo
Copy link

mo commented Nov 8, 2024

great! thanks for fixing it @lupomontero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants