-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node 22 Warning #323
Comments
The issue has been fixed already in #298, but no new version of this package has been published since 2022. @lupomontero could you please update the version in package.json to 1.9.1 and publish to npm? Thanks a lot in advance! (This is relatively serious since |
@BenjaminAster There is no 1.9.1 in npm, https://www.npmjs.com/package/psl?activeTab=versions history shows last published version was 1.9.0. |
@ackava Sorry if I was unclear in my wording – this is exactly what I meant; @lupomontero should publish a new version to npm (1.9.0 is the current version, so 1.9.1 or possibly 1.10.0 would be the next one). |
@BenjaminAster Sorry, I thought you were the author. I checked the builds and last build has failed and I hope authors publish. However I checked tough-cookie, they have pre release build in which they have removed |
Thanks for that @BenjaminAster. { ... then pnpm install. |
just ran in to this deprecation -- would love to see a new release |
Up |
Yeahhh, would love it too |
node 22 is very soon LTS... would be really nice with a new release of psl that doesn't use punycode |
`psl` is one of the deps causing the `punycode` deprecation warning on Node 22. [The newest version includes the deprecation warning](lupomontero/psl#323), so we can't just update `psl`. Inspired by salesforce/tough-cookie#346.
Hi there, many apologies for taking so long to address this... I have just released a new version that should include a fix for this issue: https://github.com/lupomontero/psl/releases/tag/v1.10.0 |
thank you! |
great! thanks for fixing it @lupomontero |
DeprecationWarning: The
punycode
module is deprecated. Please use a userland alternative instead.As per
punnycode
, https://www.npmjs.com/package/punycode ,require("punnycode")
should be replaced withrequire("punnycode/")
The text was updated successfully, but these errors were encountered: