Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Replaces deprecated Punycode provided by Node with punycode.js #298

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

lupomontero
Copy link
Owner

@lupomontero lupomontero commented Jul 4, 2022

Node's Punycode module has been deprecated for years as pointed out by @Macil in #296.

This PR replaces the deprecated module with mathiasbynens/punycode.js as suggested.

@lupomontero lupomontero self-assigned this Jul 4, 2022
@gboer
Copy link

gboer commented Sep 7, 2022

any idea when this can be merged? Would be nice to not have the deprecation warning anymore after this is in :)

@brycefranzen
Copy link

When will this be merged?

@SimenB
Copy link

SimenB commented Sep 9, 2023

@lupomontero punycode is runtime deprecated in the upcoming Node v21, printing a noisy deprecation warning. Do you think you can land this and release a patch? 🙂

@dmitryplatonov
Copy link

Node v21 is released, and it's complaining about deprecated punycode module. Can this be merged?

@lupomontero lupomontero merged commit 495ff6c into main Jan 8, 2024
@lupomontero lupomontero deleted the punycode.js branch January 8, 2024 11:26
@MikeMcC399
Copy link

@lupomontero

Are you planning to release a new version now?

v1.9.0 is still the latest release.

@ravanscafi
Copy link

@lupomontero any chance you could tag this new version? we are still getting the old one, so merging the PR didn't help to solve the problem completely.

thank you!

@alexharpin
Copy link

@lupomontero It looks like this didn't get published as it's still showing 1.9.0 as the latest release. Any chance of getting this published, especially as you've already done the work on resolving it?

@mohd-akram
Copy link

Any update on a release with this fix?

@michaelrommel
Copy link

Please update the npm release!

@ljharb
Copy link

ljharb commented Sep 26, 2024

To be clear, this is a breaking change, because punycode.js v2 doesn't support the same engines as this package (namely, all of them).

If it's changed to v1, it'll be a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on deprecated Node "punycode" module