-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Replaces deprecated Punycode provided by Node with punycode.js #298
Conversation
any idea when this can be merged? Would be nice to not have the deprecation warning anymore after this is in :) |
When will this be merged? |
@lupomontero |
Node v21 is released, and it's complaining about deprecated punycode module. Can this be merged? |
Are you planning to release a new version now? v1.9.0 is still the latest release. |
@lupomontero any chance you could tag this new version? we are still getting the old one, so merging the PR didn't help to solve the problem completely. thank you! |
@lupomontero It looks like this didn't get published as it's still showing 1.9.0 as the latest release. Any chance of getting this published, especially as you've already done the work on resolving it? |
Any update on a release with this fix? |
Please update the npm release! |
To be clear, this is a breaking change, because punycode.js v2 doesn't support the same engines as this package (namely, all of them). If it's changed to v1, it'll be a patch. |
Node's
Punycode
module has been deprecated for years as pointed out by @Macil in #296.This PR replaces the deprecated module with mathiasbynens/punycode.js as suggested.