Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

punycode is deprecated in Node v21 #315

Closed
AnWeber opened this issue Nov 1, 2023 · 8 comments
Closed

punycode is deprecated in Node v21 #315

AnWeber opened this issue Nov 1, 2023 · 8 comments

Comments

@AnWeber
Copy link

AnWeber commented Nov 1, 2023

Using punycode is deprecated in Node v21. See documentation https://nodejs.org/api/punycode.html. Maybe try replacing with NPM Package punycode

punycode is used here:

psl/index.js

Line 5 in 797ccb4

var Punycode = require('punycode');

Fix:

  1. npm i punycode
  2. change from require("punycode") to require("punycode/")

AnWeber/httpyac#577

@AnWeber
Copy link
Author

AnWeber commented Nov 3, 2023

There is already a pull request from 2022 fixing this issue.

#298

@quinton-ashley
Copy link

@lupomontero

@ryuujo1573
Copy link

ryuujo1573 commented Feb 5, 2024

3ddec00
See this commit and it may suggest that new version be released soon.

@jm42
Copy link

jm42 commented Mar 4, 2024

This is already fixed. We are just waiting for a new release. Patience is a virtue.

@MikeMcC399
Copy link

@jm42

This is already fixed. We are just waiting for a new release. Patience is a virtue.

Can you clarify why you suggest just waiting? Are you a maintainer and you are planning a release?

It's 2 months ago since @lupomontero added a series of commits into the master branch including the fix 3ddec00 for this issue.

If you are not a maintainer, then perhaps @lupomontero could say if/when a new release is planned?

@skagedal
Copy link

skagedal commented May 2, 2024

Thank you for maintaining this package! I understand that it is a lot of work. It would be appreciated with a release that includes thix fix.

@NullVoxPopuli
Copy link

NullVoxPopuli commented Sep 25, 2024

when is the next release? it's been almost a year.

thanks!

(also if you want help, I can lend a hand! I manage a fair number of packages)
(I know this reads as spam / malicious, I'm sorry, I don't know how to make it sound nicer)
image

@lupomontero
Copy link
Owner

Hi there, many apologies for taking so long to address this... I have just released a new version that should include a fix for this issue: https://github.com/lupomontero/psl/releases/tag/v1.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants