Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address misleading warnings from rollup about externals #1015

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 4, 2021

When building a v2 addon we deliberately don't want rollup to do anything with imports of our dependencies or the various ember-provided package names we might refer to. And that is what already happens, except rollup emits warnings about them.

This adds a plugin that handles these dependenices correctly, making them explicitly as external so there's no warning, while ensuring that if you stray from the allowed resolvable dependencies you will still see warnings.

When building a v2 addon we deliberately *don't* want rollup to do anything with imports of our dependencies or the various ember-provided package names we might refer to. And that is what already happens, except rollup emits warnings about them.

This adds a plugin that handles these dependenices correctly, making them explicitly as external so there's no warning, while ensuring that if you stray from the allowed resolvable dependencies you will still see warnings.
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@ef4 ef4 merged commit e3acdb3 into master Nov 5, 2021
@ef4 ef4 deleted the addon-dev-externals branch November 5, 2021 18:26
@rwjblue rwjblue added the bug Something isn't working label Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants