Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Resolver: Virtual test-support.css #1811

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Module Resolver: Virtual test-support.css #1811

merged 3 commits into from
Apr 10, 2024

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented Feb 22, 2024

This PR replaces the assets/test-support.css file generated in the rewritten-app with an entrypoint returning a virtual CSS:

- <link integrity="" rel="stylesheet" href="/assets/test-support.css">
+ <link integrity="" rel="stylesheet" href="/@embroider/core/test-support.css">

The content that was previously written in assets/test-support.css is now generated by the virtual-test-support-styles's functions.

How to test

  • On the main branch:
  • On the present virtual-test-support-styles branch:
  • 👀 The response should be the same CSS content for both branches
  • On the present virtual-test-support-styles branch:
    • Build the vite app in test mode (pnpm vite build --mode=test)
    • 👀 There should be a fingerprinted dist/assets/test-*.css containing the styles.
    • 👀 The stylesheet pointing to this file should be present in dist/tests/index.html

@BlueCutOfficial BlueCutOfficial changed the title Module Resolver: Virtual test support styles Module Resolver: Virtual test-support.css Feb 22, 2024
@mansona mansona force-pushed the virtual-entry-point branch 7 times, most recently from 425215f to 0c31ba0 Compare February 29, 2024 17:43
@mansona mansona force-pushed the virtual-entry-point branch 6 times, most recently from 44981c2 to 00e95a1 Compare March 12, 2024 14:38
@mansona mansona force-pushed the virtual-entry-point branch 2 times, most recently from f61220a to 9d46807 Compare April 3, 2024 11:41
@BlueCutOfficial BlueCutOfficial changed the base branch from virtual-entry-point to main April 3, 2024 11:48
@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review April 4, 2024 07:49
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 LGTM 💪

@mansona mansona added the enhancement New feature or request label Apr 10, 2024
@mansona mansona merged commit ea2a455 into embroider-build:main Apr 10, 2024
90 of 91 checks passed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants