Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scenario-tester #1931

Merged
merged 3 commits into from
Jul 3, 2024
Merged

update scenario-tester #1931

merged 3 commits into from
Jul 3, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented May 20, 2024

While working on #1930 I noticed some scenarios were falling even though I didn't expect them to be any different 🤔

This PR is to update scenario-tester to rule out any issues in the upgrade 👍

@BlueCutOfficial
Copy link
Collaborator

BlueCutOfficial commented Jun 28, 2024

lts_4_4-compat-app-script-attributes (and probably most of the lts_4_4 issues)

In some tests, the rewritten-packages contain multiple copies of @ember-data/store. Only one copy has content, the others are empty. During the build process, an import of the store resolves to a wrong empty copy.

At this point, I don't know exactly how it happens but each package in ember-data/node_modules/@ember-data/ uses its own copy of the @ember-data/store 4.4.3 and @ember-data/private-build-infra 4.4.3. This is highlighted by the build errors messages: store.0475f66d can’t be imported from adapter.f16145ac, store.1b5d0016 can’t be imported from model.47daea97, etc... The issue happens with store and private-build-infra but doesn’t impact canary-features, which is a dependency of several @ember-data/* packages but not ember-data itself.

What makes the packages empty is this hook in @ember-data/private-build-infra. This exact file no longer exists in the latest EmberData (the release note for 5.3.0 mentions a deprecation removal). WhenshouldIncludeChildAddon hook isn't defined the multiple copies still exist, but the build works because they are not empty: this code is not executed.

In the release-compat-app-script-attributes scenario, we have only single copy of each package in rewritten-packages/@ember-data.

@mansona mansona merged commit a8c9dfe into stable Jul 3, 2024
201 checks passed
@mansona mansona deleted the scenario-tester branch July 3, 2024 15:03
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants