output macros-config.json and _babel_config_ in the .embroider folder #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er folder so it's separated from the rewritten-app
BlueCutOfficial
force-pushed
the
align-package-json-mcros-config
branch
7 times, most recently
from
7295b17
to
e970959
Compare
…r folder so it's separated from the rewritten-app
BlueCutOfficial
force-pushed
the
align-package-json-mcros-config
branch
from
e970959
to
187f072
Compare
mansona
changed the title
This was referenced May 22, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We are still working on removing the rewritten app completely. To achieve this goal, we need to remove all the remaining differences between the initial Ember app and the rewritten app generated at stage 2.
One of these differences is the presence of
macros-config.jsonand_babel_config_.jsin the root folder of the rewritten-app.Solution
Instead of outputting
macros-config.jsonand_babel_config_.jsin the rewritten app, we now output them directly in the.embroiderfolder, which contains all the config files we need.