Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] Update release deps #2069

Draft
wants to merge 3 commits into
base: stable
Choose a base branch
from
Draft

[stable] Update release deps #2069

wants to merge 3 commits into from

Conversation

NullVoxPopuli
Copy link
Collaborator

Followup to #2068
Currently still exploring what combination of things could be causing something I'm seeing locally.

@NullVoxPopuli NullVoxPopuli self-assigned this Aug 21, 2024
@NullVoxPopuli
Copy link
Collaborator Author

NullVoxPopuli commented Aug 21, 2024 •
edited
Loading

I don't know how the bootstrap tests were ever passing.

[BABEL]: Cannot find module '@babel/helper-module-imports'
Require stack:
- <output>/node_modules/ember-bootstrap/node_modules/ember-concurrency/lib/babel-plugin-transform-ember-concurrency-async-tasks.js

ember-bootstrap v5 depends on ember-concurrency ^2.1.2 -- and even on the latest v2, @babel/helper-module-imports is not provided in dependencies:
https://github.com/machty/ember-concurrency/blob/2.3.7/package.json#L104-L112

@NullVoxPopuli NullVoxPopuli changed the title Update release deps [stable] Update release deps Aug 21, 2024
@NullVoxPopuli
Copy link
Collaborator Author

With Vite, I was actually able to debug some of this: #2070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NullVoxPopuli NullVoxPopuli

Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NullVoxPopuli