Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember standard modules to include @ember/renderer and @ember/-internals and ember-testing #2075

Merged
merged 2 commits into from
Aug 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/shared-internals/src/ember-standard-modules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ emberVirtualPeerDeps.add('@ember/string');
// (like snowpack) not to worry about these packages.
emberVirtualPackages.add('@glimmer/env');
emberVirtualPackages.add('ember');
emberVirtualPackages.add('ember-testing');

// this is a real package and even though most of its primary API is implemented
// as transforms, it does include some runtime code.
Expand All @@ -45,6 +46,13 @@ emberVirtualPeerDeps.add('ember-source');
// the modules-api-polyfill. Newer APIs need to be added here.
emberVirtualPackages.add('@ember/owner');

// Added in ember-source 4.5.0-beta.1
emberVirtualPackages.add('@ember/renderer');

// Not provided by rfc176-data, but is needed for special librarys
// that know the dangers of importing private APIs
emberVirtualPackages.add('@ember/-internals');

// these are not public API but they're included in ember-source, so for
// correctness we still want to understand that they come from there.
emberVirtualPackages.add('@glimmer/validator');
Expand Down