Hide base path from public URL of rollup-public-assets #2082
Conversation
|
@mansona does release-plan expect an additional/different label other than |
|
@simonihmig no all you need is to define this as breaking and it will make it a major bump 👍 |
| @@ -51,7 +51,7 @@ export default function publicAssets( | |||
| }); | |||
| const publicAssets: Record<string, string> = filenames.reduce( | |||
| (acc: Record<string, string>, v): Record<string, string> => { | |||
| const namespace = opts?.namespace ?? join(pkg.name, path); | |||
| const namespace = opts?.namespace ?? pkg.name; | |||
There was a problem hiding this comment.
doesn't this mean that all the public assets will just be flattened 🤔 you can't have any structure at all any more
There was a problem hiding this comment.
@mansone No, this is just the namespace, that is statically added to any file that is within the assets folder. Let's say the package name is fancy-addon, and its rollup config has addon.publicAssets('src/assets/public'), and it has a file in src/assets/public/foo/bar.jpg. Then before this change the plugin would add this to the package.json:
"public-assets": {
"./src/assets/public/foo/bar.jpg": "fancy-addon/src/assets/public/foo/bar.jpg"
}
With this PR it would be:
"public-assets": {
"./src/assets/public/foo/bar.jpg": "fancy-addon/foo/bar.jpg"
}
path in L54 would be src/assets/public in this example (as passed to the plugin), so that gets removed here.
As discussed in yesterday's team meeting, after some previous back and forth and confusion around where breaking changes should go into (
mainvs.stable), this PR is applying the same (breaking!) change that landed inmain(#1972) to stable, so we can get this published (as yet another new major unfortunately) without waiting formainto stabilize.More context in #1697 (comment)...