bundle up vite plugins in a nicer way #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evoactivity
reviewed
Nov 26, 2024
evoactivity
reviewed
Nov 26, 2024
evoactivity
reviewed
Nov 26, 2024
evoactivity
reviewed
Nov 26, 2024
evoactivity
reviewed
Nov 26, 2024
|
Generally looks good, I left a few comment and a question :) |
ef4
approved these changes
Dec 3, 2024
evoactivity
approved these changes
Dec 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the suggestion of @evoactivity on the v2 app blueprint RFC
We discussed the structure at the Embroider office hours and meeting and agreed that this is pretty close to what we're hoping to ship with
Closes #2183